fix: ensure problematic push subscriptions are always removed on any error

backend/src/handlers/notifications.rs

@@ -16,9 +16,15 @@ pub async fn torrent_finished_handler(
     State(state): State<AppState>,
     Query(params): Query<TorrentFinishedQuery>,
 ) -> StatusCode {
-    tracing::info!("Torrent finished notification received: {} ({})", params.name, params.hash);
+    tracing::info!("WEBHOOK: Received notification from rTorrent. Name: {:?}, Hash: {:?}", params.name, params.hash);
 
-    let message = format!("Torrent tamamlandı: {}", params.name);
+    let torrent_name = if params.name.is_empty() || params.name == "$d.name=" {
+        "Bilinmeyen Torrent".to_string()
+    } else {
+        params.name.clone()
+    };
+
+    let message = format!("Torrent tamamlandı: {}", torrent_name);
 
     // 1. Send to active SSE clients (for Toast)
     let notification = SystemNotification {
@@ -33,13 +39,13 @@ pub async fn torrent_finished_handler(
         let push_store = state.push_store.clone();
         let title = "Torrent Tamamlandı".to_string();
         let body = message;
-        let torrent_name = params.name.clone();
+        let name_for_log = torrent_name.clone();
         
         tokio::spawn(async move {
-            tracing::info!("Attempting to send Web Push notification for torrent: {}", torrent_name);
+            tracing::info!("Attempting to send Web Push notification for torrent: {}", name_for_log);
             match crate::push::send_push_notification(&push_store, &title, &body).await {
-                Ok(_) => tracing::info!("Web Push notification sent successfully for: {}", torrent_name),
-                Err(e) => tracing::error!("Failed to send Web Push notification for {}: {:?}", torrent_name, e),
+                Ok(_) => tracing::info!("Web Push notification task completed for: {}", name_for_log),
+                Err(e) => tracing::error!("Failed to send Web Push notification for {}: {:?}", name_for_log, e),
             }
         });
     }

backend/src/push.rs

@@ -191,11 +191,21 @@ pub async fn send_push_notification(
                                                 tracing::debug!("Push notification sent to: {}", subscription.endpoint);
                                             }
                                             Err(e) => {
-                                                tracing::error!("Failed to send push notification to {}: {}", subscription.endpoint, e);
+                                                let err_msg = format!("{:?}", e);
+                                                tracing::error!("Delivery failed for {}: {}", subscription.endpoint, err_msg);
+                                                // Always remove on delivery failure (Gone, Unauthorized, etc.)
+                                                tracing::info!("Removing problematic subscription after delivery failure: {}", subscription.endpoint);
+                                                let _ = store.remove_subscription(&subscription.endpoint).await;
                                             }
                                         }
                                     }
-                                    Err(e) => tracing::error!("Failed to build push message: {}", e),
+                                    Err(e) => {
+                                        let err_msg = format!("{:?}", e);
+                                        tracing::error!("Encryption/Build failed for {}: {}", subscription.endpoint, err_msg);
+                                        // Always remove on encryption failure
+                                        tracing::info!("Removing problematic subscription after encryption failure: {}", subscription.endpoint);
+                                        let _ = store.remove_subscription(&subscription.endpoint).await;
+                                    }
                                 }
                             }
                             Err(e) => tracing::error!("Failed to build VAPID signature: {}", e),